Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix async usage in app startup #4285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix async usage in app startup #4285

wants to merge 1 commit into from

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Oct 25, 2024 •
edited
Loading

Removes a lot of Task was destroyed but it is pending! warnings during tests

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 25, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 25, 2024
ogabrielluiz
ogabrielluiz approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz