feat: add minimize and expand functionality for UI nodes #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on showNode state 🔧 (frontend): update node internals when toggling showNode state 📝 (frontend): add test for minimizing and expanding components
dosubot
bot
added
the
size:L
dosubot
bot
added
enhancement
github-actions
bot
added
bug
…on to improve code readability and maintainability 🔧 (handleRenderComponent/index.tsx): refactor handleClick function to improve code readability and maintainability
…into cz/minimize
Cristhianzl
changed the title
Cristhianzl
changed the title
github-actions
bot
added
enhancement
CodSpeed Performance ReportMerging #4388 will degrade performances by 22.56%Comparing Summary
Benchmarks breakdown
|
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…#4388) * ✨ (frontend): improve UI by dynamically showing/hiding elements based on showNode state 🔧 (frontend): update node internals when toggling showNode state 📝 (frontend): add test for minimizing and expanding components * 🔧 (handleRenderComponent/index.tsx): refactor getHandleClasses function to improve code readability and maintainability 🔧 (handleRenderComponent/index.tsx): refactor handleClick function to improve code readability and maintainability --------- Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that allows users to minimize and expand nodes in the UI. It includes changes to the frontend components, styles, and tests to support this functionality. The most important changes include updates to the
GenericNodeandHandleRenderComponentcomponents, as well as new styles and tests.Feature Implementation
src/frontend/src/CustomNodes/GenericNode/index.tsx: Updated theGenericNodecomponent to conditionally render different styles and elements based on theshowNodestate. [1] [2] [3] [4] [5]src/frontend/src/CustomNodes/GenericNode/components/NodeName/index.tsx: Modified theNodeNamecomponent to handle double-click events and adjust styles based on theshowNodestate.src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx: Adjusted theNodeOutputFieldcomponent to render theHandlewhenshowNodeis false.src/frontend/src/CustomNodes/GenericNode/components/handleRenderComponent/index.tsx: Updated theHandleRenderComponentto measure node dimensions and adjust styles based on theshowNodestate. [1] [2] [3] [4]src/frontend/src/CustomNodes/GenericNode/components/nodeIcon/index.tsx: Modified theNodeIconcomponent to adjust styles based on theshowNodestate.Style Adjustments
src/frontend/src/style/applies.css: Updated styles for various classes to support the new minimize and expand functionality. [1] [2] [3]src/frontend/src/style/classes.css: Added new styles for handle elements whenshowNodeis false.Testing
src/frontend/tests/extended/features/minimize.spec.ts: Added a new test to verify that users can minimize and expand a component.