Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a WikiData API Tool Component #4512

Merged
merged 8 commits into from
Nov 12, 2024
Merged

feat: Add a WikiData API Tool Component #4512

merged 8 commits into from
Nov 12, 2024

Conversation

erichare
Copy link
Collaborator

This pull request adds a tool, using the new format modeled from the improve-tools PR, for pulling WikiData data using the API and returning a Data object (+ a Tool object) with the search results from the API.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 11, 2024
@dosubot dosubot bot added the enhancement New feature or request label Nov 11, 2024
@erichare erichare enabled auto-merge (squash) November 11, 2024 23:31
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4512 will degrade performances by 13.62%

Comparing feat-wikidata-component (d1eef7c) with main (516ba89)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat-wikidata-component Change
❌ test_invalid_run_with_input_type_chat 14.1 ms 16.3 ms -13.62%
⚡ test_successful_run_with_input_type_any 505 ms 458.2 ms +10.23%
⚡ test_successful_run_with_output_type_any 456.2 ms 412.9 ms +10.49%

@erichare erichare disabled auto-merge November 11, 2024 23:42
ogabrielluiz
ogabrielluiz approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

After the release we should move to .invoke calls. I have a branch with a bunch of tool updates btw

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@erichare erichare enabled auto-merge (squash) November 12, 2024 14:42
@erichare erichare merged commit 8cd8721 into main Nov 12, 2024
29 checks passed
@erichare erichare deleted the feat-wikidata-component branch November 12, 2024 15:03
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@erichare @autofix-ci @diogocabral
feat: Add a WikiData API Tool Component (langflow-ai#4512)
1815b8e 
* feat: Add a WikiData API Tool Component

* [autofix.ci] apply automated fixes

* Update wikidata_api.py

* Fix casing and import in init

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erichare @ogabrielluiz