Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): Add drag prevention to popover and improve icon fallback handling #4544

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request includes updates to the inputComponent to enhance functionality and improve the user interface. The most important changes involve adding a new class to the popover input and modifying the icon name handling.

User Interface Improvements:

Functionality Enhancements:

…to prevent dragging

📝 (index.tsx): provide default icon name 'ChevronsUpDown' if getIconName function returns falsy value
@Cristhianzl Cristhianzl self-assigned this Nov 12, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Nov 12, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 12, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) November 12, 2024 19:47
@ogabrielluiz ogabrielluiz merged commit 1199690 into main Nov 12, 2024
19 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fix-drag-input branch November 12, 2024 23:28
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants