Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing sqlite dialect #4599

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: missing sqlite dialect #4599

merged 1 commit into from
Nov 14, 2024

Conversation

italojohnny
Copy link
Member

Fixes missing sqlite dialect in SQLAlchemy connection

Fixes: #4572

@italojohnny italojohnny requested a review from cbornet November 14, 2024 14:01
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 14, 2024
@italojohnny italojohnny force-pushed the fix/missing-sqlite-dialect branch from f2f8219 to 1d2a164 Compare November 14, 2024 14:03
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #4599 will degrade performances by 28.24%

Comparing fix/missing-sqlite-dialect (688d15c) with main (af54655)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/missing-sqlite-dialect Change
test_invalid_run_with_input_type_chat 13.7 ms 19.1 ms -28.24%
test_successful_run_with_input_type_text 205.2 ms 128.8 ms +59.32%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@ogabrielluiz ogabrielluiz force-pushed the fix/missing-sqlite-dialect branch from 1d2a164 to 688d15c Compare November 14, 2024 16:15
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 14, 2024 16:27
@ogabrielluiz ogabrielluiz merged commit 7d9315b into main Nov 14, 2024
20 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/missing-sqlite-dialect branch November 14, 2024 16:30
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
fix: missing sqlite dialect import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Langflow not starting with postgres - giving Sqlite error
3 participants