fix: updated node toolbar to be more stable on zoom, fix success and error component tooltips, unselect nodes on flow opening #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
dosubot
bot
added
size:XL
deon-sanchez
approved these changes
Nov 15, 2024
|
This test passes on all other branches so I can't merge this until it is fixed @lucaseduoli |
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Nov 22, 2024
…error component tooltips, unselect nodes on flow opening (langflow-ai#4610) * Unselect nodes and edges on enter * Start with viewport fit * Fix run component tooltip to match error and success * Update scrollbar design * Added node toolbar without portal to match the width of the node * Updated color of scrollbar * Updated NoteNode to have same behavior as GenericNode * Updated logic for tests to pass * Fix fitview to only occur when nodes are present * Update z index of resize handle * Sticky notes test fix * [autofix.ci] apply automated fixes * freeze test fixed --------- Co-authored-by: Mike Fortman <michael.fortman@datastax.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: anovazzi1 <otavio2204@gmail.com> Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org> Co-authored-by: Cristhian Zanforlin Lousa <cristhian.lousa@gmail.com>
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…error component tooltips, unselect nodes on flow opening (langflow-ai#4610) * Unselect nodes and edges on enter * Start with viewport fit * Fix run component tooltip to match error and success * Update scrollbar design * Added node toolbar without portal to match the width of the node * Updated color of scrollbar * Updated NoteNode to have same behavior as GenericNode * Updated logic for tests to pass * Fix fitview to only occur when nodes are present * Update z index of resize handle * Sticky notes test fix * [autofix.ci] apply automated fixes * freeze test fixed --------- Co-authored-by: Mike Fortman <michael.fortman@datastax.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: anovazzi1 <otavio2204@gmail.com> Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org> Co-authored-by: Cristhian Zanforlin Lousa <cristhian.lousa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance the user interface, refactor code, and improve the functionality of the
NodeToolbarComponentand related components. The most important changes include modifications to the scrollbar styles, refactoring of theNodeToolbarComponent, and updates to theNodeStatuscomponent.User Interface Enhancements:
src/frontend/src/App.css: Updated scrollbar styles, including changing the background color of the scrollbar thumb and hover states.Code Refactoring:
src/frontend/src/CustomNodes/GenericNode/index.tsx: Refactored the toolbar component to use adivinstead ofNodeToolbar, and moved the toolbar rendering inside the main node container. [1] [2] [3] [4]src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx: Removed unnecessary zoom scaling logic and replacedSelectContentwithSelectContentWithoutPortalfor better performance. [1] [2] [3] [4] [5]Component Updates:
src/frontend/src/CustomNodes/GenericNode/components/NodeStatus/index.tsx: Added conditional styling toShadTooltipand updated the layout and styling of validation messages and run timestamps. [1] [2]Utility and Store Enhancements:
src/frontend/src/stores/flowStore.ts: AddedunselectAllNodesEdgesutility function to ensure nodes and edges are unselected when updating the flow store. [1] [2]src/frontend/src/utils/reactflowUtils.ts: Removed unused typeunselectAllNodesType. [1] [2]Minor Fixes:
src/frontend/src/style/classes.css: Enabled pointer events for the.react-flow__paneclass.src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx: EnabledfitViewproperty for the flow page component.