Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for dynamic providers in Astra DB Comp #4627

Merged
merged 10 commits into from
Nov 18, 2024

Conversation

erichare
Copy link
Collaborator

@erichare erichare commented Nov 14, 2024

This pull requests dynamically updates the list of vectorize providers when a user provider their api endpoint and token.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Nov 14, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 14, 2024
@erichare erichare self-assigned this Nov 14, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
@erichare
Copy link
Collaborator Author

CC @jeffreyscarpenter

@erichare erichare requested a review from cbornet November 15, 2024 20:06
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@erichare erichare enabled auto-merge (squash) November 18, 2024 22:33
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4627 will degrade performances by 26.7%

Comparing feat-4626-dynamic-providers (489cdfe) with main (3d768ea)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat-4626-dynamic-providers Change
test_successful_run_with_input_type_any 298.8 ms 219 ms +36.45%
test_successful_run_with_output_type_debug 217.2 ms 296.3 ms -26.7%

@erichare erichare merged commit 3188517 into main Nov 18, 2024
32 checks passed
@erichare erichare deleted the feat-4626-dynamic-providers branch November 18, 2024 22:42
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 19, 2024
…#4627)

* feat: Add support for dynamic providers in Astra DB Comp

* [autofix.ci] apply automated fixes

* Make sure we return a default dict

* Rename params in starter template

* Update test_vector_store_rag.py

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…#4627)

* feat: Add support for dynamic providers in Astra DB Comp

* [autofix.ci] apply automated fixes

* Make sure we return a default dict

* Rename params in starter template

* Update test_vector_store_rag.py

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically build the embedding providers/models map in AstraVectorStoreComponent
2 participants