Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use AsyncSession in build_graph_from_db #4649

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 16, 2024

Use AsyncSession in build_graph_from_db

@cbornet cbornet requested a review from ogabrielluiz November 16, 2024 16:44
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 16, 2024
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #4649 will degrade performances by 45.11%

Comparing cbornet:async-session-build-graph (f1c6497) with main (efe6407)

Summary

❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:async-session-build-graph Change
test_successful_run_with_input_type_any 163.6 ms 298.1 ms -45.11%
test_successful_run_with_output_type_debug 197.1 ms 296.1 ms -33.44%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 17, 2024
@cbornet cbornet merged commit da01f5c into langflow-ai:main Nov 17, 2024
30 of 37 checks passed
@cbornet cbornet deleted the async-session-build-graph branch November 17, 2024 11:35
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants