Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure chat inputs with dependencies are not prioritized in graph sorting #4666

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request modifies the sorting logic for chat inputs in the graph. It ensures that chat inputs with dependencies are not moved to the first layer, maintaining their original order when dependencies exist. This change improves the handling of chat inputs in the graph structure.

Fixes #4660

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 18, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4666 will improve performances by 32.03%

Comparing fix-chatinput-sorting (79c98fa) with main (a86a7a2)

Summary

⚡ 2 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-chatinput-sorting Change
test_successful_run_with_output_type_any 288.5 ms 218.5 ms +32.03%
test_successful_run_with_output_type_debug 216.6 ms 174.9 ms +23.86%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 18, 2024 15:13
@ogabrielluiz ogabrielluiz merged commit 1362062 into main Nov 18, 2024
20 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-chatinput-sorting branch November 18, 2024 15:35
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…h sorting (langflow-ai#4666)

Ensure chat inputs with dependencies are not sorted to the first layer in graph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat input component does not accept text input
2 participants