Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure attribute existence before accessing in AgentExecutor initialization #4667

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: Ensure attribute existence before accessing in AgentExecutor initialization #4667

merged 2 commits into from
Nov 18, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This PR fixes issue #4663 by avoiding AttributeErrors

@ogabrielluiz ogabrielluiz linked an issue Nov 18, 2024 that may be closed by this pull request
SQLAgent requiring "chat_history"? #4663
Closed
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 18, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 18, 2024 12:43
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4667 will degrade performances by 40.8%

Comparing 4663-sqlagent-requiring-chat_history (b0b6dc0) with main (a7aa3ab)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 4663-sqlagent-requiring-chat_history Change
❌ test_successful_run_with_input_type_text 175.6 ms 296.6 ms -40.8%
⚡ test_successful_run_with_output_type_any 311.6 ms 219.4 ms +42.02%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@ogabrielluiz ogabrielluiz merged commit 95779c8 into main Nov 18, 2024
28 of 36 checks passed
@ogabrielluiz ogabrielluiz deleted the 4663-sqlagent-requiring-chat_history branch November 18, 2024 13:38
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@ogabrielluiz @diogocabral
fix: Ensure attribute existence before accessing in AgentExecutor ini…
83133cd 
…tialization (langflow-ai#4667)

* Add attribute check for 'chat_history' before accessing it in agent.py

* Ensure attribute existence before accessing in AgentExecutor initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italojohnny italojohnny italojohnny approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLAgent requiring "chat_history"?
2 participants
@ogabrielluiz @italojohnny