Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add check for 'set_event_manager' method in custom_component before calling it #4668

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: Add check for 'set_event_manager' method in custom_component before calling it #4668

merged 1 commit into from
Nov 18, 2024

Conversation

ogabrielluiz
Copy link
Contributor

Add attribute check before calling set_event_manager to avoid AttributeError in components inheriting from CustomComponent.

@ogabrielluiz ogabrielluiz linked an issue Nov 18, 2024 that may be closed by this pull request
SQL Query component doesn't work #4662
Closed
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 18, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 18, 2024 12:49
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4668 will improve performances by 31.06%

Comparing 4662-sql-query-component-doesnt-work (2b4b4a7) with main (95779c8)

Summary

⚡ 2 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main 4662-sql-query-component-doesnt-work Change
⚡ test_successful_run_with_input_type_any 275.7 ms 221.1 ms +24.71%
⚡ test_successful_run_with_output_type_any 287.8 ms 219.6 ms +31.06%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@ogabrielluiz ogabrielluiz force-pushed the 4662-sql-query-component-doesnt-work branch from fd612e7 to 2b4b4a7 Compare November 18, 2024 13:46
@ogabrielluiz ogabrielluiz merged commit 9ec66cd into main Nov 18, 2024
19 checks passed
@ogabrielluiz ogabrielluiz deleted the 4662-sql-query-component-doesnt-work branch November 18, 2024 14:02
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@ogabrielluiz @diogocabral
fix: Add check for 'set_event_manager' method in custom_component bef…
e4b2b92 
…ore calling it (langflow-ai#4668)

Add check for 'set_event_manager' method in custom_component before calling it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italojohnny italojohnny italojohnny approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Query component doesn't work
2 participants
@ogabrielluiz @italojohnny