Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add worker_task attribute to TelemetryService to prevent AttributeError #4670

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This update introduces a worker_task attribute to the TelemetryService class, which helps avoid potential AttributeError issues. This change enhances the robustness of the telemetry service by ensuring that the attribute is properly initialized.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 18, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4670 will improve performances by 43.31%

Comparing fix-attribute-error-telemetry-service (7832cf1) with main (9ec66cd)

Summary

⚡ 3 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-attribute-error-telemetry-service Change
test_successful_run_with_input_type_any 298.2 ms 220.4 ms +35.29%
test_successful_run_with_output_type_any 353.2 ms 246.4 ms +43.31%
test_successful_run_with_output_type_debug 295 ms 217.6 ms +35.59%

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 18, 2024 13:45
@ogabrielluiz ogabrielluiz force-pushed the fix-attribute-error-telemetry-service branch from c0548b6 to cf422b1 Compare November 18, 2024 13:45
@ogabrielluiz ogabrielluiz force-pushed the fix-attribute-error-telemetry-service branch from cf422b1 to 7832cf1 Compare November 18, 2024 14:56
@ogabrielluiz ogabrielluiz merged commit a86a7a2 into main Nov 18, 2024
19 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-attribute-error-telemetry-service branch November 18, 2024 15:12
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…teError (langflow-ai#4670)

Add worker_task attribute to TelemetryService to avoid AttributeError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants