-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add a check in ComponentToolkit to avoid building a tool that builds tools #4678
Conversation
e5d17f1
to
99d89ba
Compare
CodSpeed Performance ReportMerging #4678 will degrade performances by 52.92%Comparing Summary
Benchmarks breakdown
|
Earlier, we added Tool mode True to the calculator. We can remove it in this PR If so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We might need to improve. The Tool creation , build_tool etc and make it consistent with the component toolkit later.
ff9dfb0
to
fd1ff9b
Compare
fd1ff9b
to
af35c37
Compare
…ilds tools (langflow-ai#4678) * Enhance tool filtering logic by adding TOOL_TYPES set for output type checking * Rename TOOL_TYPES to TOOL_TYPES_SET for clarity
This pull request includes changes to the
src/backend/base/langflow/base/tools/component_tool.py
file to enhance the tool type handling in theget_tools
function. The main changes involve the introduction of a new set of tool types and the modification of the tool filtering logic.Enhancements to tool type handling:
TOOL_TYPES_SET
containing the tool types{"Tool", "BaseTool", "StructuredTool"}
.get_tools
function to skip outputs whose types match any in theTOOL_TYPES_SET
, in addition to the existing condition onTOOL_OUTPUT_NAME
.tool_mode
fromCalculatorToolComponent