Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure the service selection comes before the choice #4692

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

erichare
Copy link
Collaborator

This pull request is a quick hotfix to the Vector RAG starter template, just to ensure the component order matches the Astra DB Vector Store component order.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 18, 2024
@dosubot dosubot bot added the bug Something isn't working label Nov 18, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2024
@erichare erichare enabled auto-merge (squash) November 18, 2024 23:30
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4692 will degrade performances by 36.09%

Comparing fix-astradb-input-order (62cece8) with main (2fa2580)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-astradb-input-order Change
test_load_flows 2.2 ms 1.3 ms +72.99%
test_successful_run_with_input_type_text 140.7 ms 218.9 ms -35.74%
test_successful_run_with_output_type_debug 139.1 ms 217.7 ms -36.09%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@erichare erichare merged commit 6133fed into main Nov 19, 2024
27 checks passed
@erichare erichare deleted the fix-astradb-input-order branch November 19, 2024 01:44
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 19, 2024
…i#4692)

* fix: Ensure the service selection comes before the choice

* Update components-vector-stores.md
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…i#4692)

* fix: Ensure the service selection comes before the choice

* Update components-vector-stores.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants