Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Test Docker Images workflow to use get_version_info #4721

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Nov 19, 2024

This pull request includes updates to the docker_test.yml workflow file to improve the version checking mechanism for Docker images.

Improvements to version checking:

  • .github/workflows/docker_test.yml: Updated the Test image job to use the get_version_info method from langflow.utils.version instead of get_version from langflow.version.version.
  • .github/workflows/docker_test.yml: Updated the Test backend image job to use the get_version_info method from langflow.utils.version instead of get_version from langflow.version.version.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 19, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 19, 2024 20:43
@dosubot dosubot bot added the bug Something isn't working label Nov 19, 2024
@ogabrielluiz ogabrielluiz force-pushed the fix-test-docker-images branch from 882cae8 to 05f7574 Compare November 19, 2024 20:44
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 19, 2024
@ogabrielluiz ogabrielluiz requested a review from Copilot November 19, 2024 20:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/backend/langflow/version/version.py:28

  • The new behavior of breaking the loop once a version is found should be covered by a test.
if _version := metadata.version(pkg_name):
@ogabrielluiz ogabrielluiz changed the title fix: Stop version retrieval once one is found to avoid overwriting the variable fix: update Test Docker Images workflow to use get_version_info Nov 19, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 19, 2024
@ogabrielluiz ogabrielluiz requested a review from Copilot November 19, 2024 21:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

src/backend/langflow/version/version.py:32

  • [nitpick] The error message 'Package not found from options {pkg_names}' is unclear. It should be more specific, such as 'No package found matching any of the provided names: {pkg_names}'.
msg = f"Package not found from options {pkg_names}"

src/backend/langflow/version/version.py:28

  • The new logic for breaking out of the loop when a version is found should be covered by tests to ensure it works as intended.
if _version := metadata.version(pkg_name):
@ogabrielluiz ogabrielluiz requested a review from Copilot November 19, 2024 21:09

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@ogabrielluiz ogabrielluiz force-pushed the fix-test-docker-images branch from 6814792 to 1abeb92 Compare November 19, 2024 21:47
@ogabrielluiz ogabrielluiz merged commit ffd9eaa into main Nov 19, 2024
7 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-test-docker-images branch November 19, 2024 21:48
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 22, 2024
…flow-ai#4721)

Update Docker test workflow to use get_version_info function for version retrieval
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…flow-ai#4721)

Update Docker test workflow to use get_version_info function for version retrieval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants