-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Test Docker Images workflow to use get_version_info #4721
Conversation
882cae8
to
05f7574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
src/backend/langflow/version/version.py:28
- The new behavior of breaking the loop once a version is found should be covered by a test.
if _version := metadata.version(pkg_name):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
src/backend/langflow/version/version.py:32
- [nitpick] The error message 'Package not found from options {pkg_names}' is unclear. It should be more specific, such as 'No package found matching any of the provided names: {pkg_names}'.
msg = f"Package not found from options {pkg_names}"
src/backend/langflow/version/version.py:28
- The new logic for breaking out of the loop when a version is found should be covered by tests to ensure it works as intended.
if _version := metadata.version(pkg_name):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
0273669
to
6814792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
6814792
to
1abeb92
Compare
…flow-ai#4721) Update Docker test workflow to use get_version_info function for version retrieval
…flow-ai#4721) Update Docker test workflow to use get_version_info function for version retrieval
This pull request includes updates to the
docker_test.yml
workflow file to improve the version checking mechanism for Docker images.Improvements to version checking:
.github/workflows/docker_test.yml
: Updated theTest image
job to use theget_version_info
method fromlangflow.utils.version
instead ofget_version
fromlangflow.version.version
..github/workflows/docker_test.yml
: Updated theTest backend image
job to use theget_version_info
method fromlangflow.utils.version
instead ofget_version
fromlangflow.version.version
.