fix: Gracefully handle missing imports for model components #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
github-actions
bot
added
bug
CodSpeed Performance ReportMerging #4743 will improve performances by 39.22%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
force-pushed
the
fix-imports-model-constants
branch
from
878693a to
e28c501
Compare
github-actions
bot
added
bug
edwinjosechittilappilly
approved these changes
Nov 21, 2024
ogabrielluiz
force-pushed
the
fix-imports-model-constants
branch
from
e28c501 to
c50c8e1
Compare
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Nov 22, 2024
…-ai#4743) * Handle ImportError for langchain_groq in Groq model initialization * Refactor model input constants to handle missing imports gracefully * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…-ai#4743) * Handle ImportError for langchain_groq in Groq model initialization * Refactor model input constants to handle missing imports gracefully * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when trying to import anything from langflow-base. Since we were importing packages that are not installed in langflow-base it would raise an exception.
This pull request refactors the model input constants to manage missing imports more gracefully. It introduces error handling for ImportError exceptions in the initialization of various model components, including OpenAI, Azure OpenAI, Groq, Anthropic, NVIDIA, and Amazon Bedrock. This ensures that informative error messages are provided when required packages are not installed, improving the user experience and debugging process.