fix: update design of update component #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Nov 22, 2024
* Added warning color * Implemented more colors * Implemented warning button variant * Added warning section to node * Removed warning button and added warning outline to outdated components * Added negative margin top to node for it to not move when updatable * Fixed border to be consistent * removed unused code * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* Added warning color * Implemented more colors * Implemented warning button variant * Added warning section to node * Removed warning button and added warning outline to outdated components * Added negative margin top to node for it to not move when updatable * Fixed border to be consistent * removed unused code * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
NodeStatusandGenericNodecomponents, as well as updates to styles and constants. The most important changes focus on improving the visual indicators and handling of outdated nodes, along with some code cleanup.Improvements to NodeStatus and GenericNode components:
src/frontend/src/CustomNodes/GenericNode/components/NodeStatus/index.tsx: Removed unused propshandleUpdateCodeandloadingUpdatefromNodeStatuscomponent and addedupdateClassfor visual indication of outdated nodes. [1] [2] [3] [4] [5] [6]src/frontend/src/CustomNodes/GenericNode/index.tsx: Added a warning banner for outdated nodes and removed the unused propshandleUpdateCodeandloadingUpdatefromGenericNodecomponent. [1] [2] [3] [4] [5]Style and constants updates:
src/frontend/src/style/index.css: Added new CSS variables for warning colors. [1] [2]src/frontend/tailwind.config.mjs: Updated Tailwind configuration to include the new warning color variables.src/frontend/src/components/ui/button.tsx: Added a newwarningvariant to the button component.Code cleanup:
src/frontend/src/CustomNodes/hooks/use-check-code-validity.tsx: Removed unused importnodeNames.src/frontend/src/CustomNodes/GenericNode/components/NodeStatus/index.tsx: Removed unused constantTOOLTIP_OUTDATED_NODE.