fix: changed tooltip position on playground to improve visibility, fixed color of theme switcher on light mode #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
github-actions
bot
added
bug
lucaseduoli
changed the title
github-actions
bot
added
bug
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Nov 22, 2024
…xed color of theme switcher on light mode (langflow-ai#4766) * Implemented avoidCollisions on ShadTooltip * Added type for avoidCollisions * Changed tooltip position for buttons on IOModal * Fix color of light theme switcher
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…xed color of theme switcher on light mode (langflow-ai#4766) * Implemented avoidCollisions on ShadTooltip * Added type for avoidCollisions * Changed tooltip position for buttons on IOModal * Fix color of light theme switcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the user interface and functionality of tooltips in the frontend components. The most important changes include modifying the behavior of tooltips to avoid collisions, updating the styling of theme buttons, and ensuring consistent tooltip behavior across different components.
Improvements to tooltip functionality:
src/frontend/src/components/shadTooltipComponent/index.tsx: Added anavoidCollisionsprop to theShadTooltipcomponent, allowing it to be set dynamically. [1] [2]src/frontend/src/types/components/index.ts: Updated theShadToolTipTypetype to include theavoidCollisionsproperty.Styling updates:
src/frontend/src/components/appHeaderComponent/components/ThemeButtons/index.tsx: Modified the hover styles for the theme buttons to improve visual feedback.Consistent tooltip behavior:
src/frontend/src/components/ui/dialog.tsx: Updated theShadTooltipwithin theDialogContentcomponent to use theavoidCollisionsprop and changed the tooltip position tobottom.src/frontend/src/modals/IOModal/newModal.tsx: Ensured theShadTooltipin theIOModalcomponent uses theavoidCollisionsprop and positioned the tooltip at thebottom.