fix: remove useSidebar to fix errors of SidebarWrapper when opening playground page #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Nov 22, 2024
…layground page (langflow-ai#4767) * Added open to data of wrapper * Fix PageComponent and Header to not use useSidebar anymore
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…layground page (langflow-ai#4767) * Added open to data of wrapper * Fix PageComponent and Header to not use useSidebar anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of the sidebar state in the frontend codebase. The main changes involve removing the
useSidebarhook and replacing it with data attributes to manage the sidebar's open state.Sidebar state management improvements:
src/frontend/src/components/ui/sidebar.tsx: Added adata-openattribute to manage the sidebar's open state.src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx: Removed theuseSidebarhook and replaced it with data attributes in various components to handle the sidebar's open state. [1] [2] [3] [4]Code cleanup:
src/frontend/src/pages/MainPage/components/header/index.tsx: Removed theuseSidebarhook and updated the class names to use data attributes for managing the sidebar's open state. [1] [2] [3]