(FR) Rule creation quart d'heure #10965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new grammar rule has been introduced in the French language module's Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Closed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml (1)
117280-117288: LGTM with suggestions for enhancement.The rule implementation correctly handles the basic case of "quart-d'heure" → "quart d'heure". The pattern matching and correction suggestion are working as intended.
Consider these enhancements:
- Add more examples to cover variations:
<example correction="quart d'heure">Je l'ai vu un <marker>quart-d'heure</marker> hier.</example> +<example correction="quart d'heure">Un <marker>quart-d'heure</marker> plus tard.</example> +<example>Il est arrivé il y a un quart d'heure.</example>
- Make the error message more informative:
-<message>L'expression <suggestion>\1 \3</suggestion> s'écrit sans trait d'union.</message> +<message>L'expression « quart d'heure » <suggestion>\1 \3</suggestion> s'écrit sans trait d'union selon l'usage standard.</message>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml (1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml (1)
117280-117280: Verify the default="temp_off" setting.The rule is currently disabled by default. Please confirm if this is intentional or if it should be enabled after testing.
GillouLT
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://app.asana.com/0/1205948788428908/1208607138266449/f and #10962
Summary by CodeRabbit