Feature: Support for PowerModelsDistribution ENGINEERING data models (breaking) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See JuliaIO/FFMPEG.jl#14 Some packages seem to be moving back to AppVeyor to test Windows because of this issue.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 35.80% 35.40% -0.41%
==========================================
Files 11 11
Lines 458 627 +169
==========================================
+ Hits 164 222 +58
- Misses 294 405 +111
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a substantial rewrite of PowerModelsAnalytics to make it more agnostic to the type of Infrastructure network that is attempting to be plotted. A lot was attempted to be abstracted away in order to allow the user to provide custom specifications for things like nodes, edges, sources, demands, etc., without having to write new functions to plot those types of Infrastructure networks. That being said, this is only currently tested with PowerModels and PowerModelsDistribution.
This PR specifically adds support for the PowerModelsDistribution ENGINEERING data model, as well as maintaining support for the MATHEMATICAL model (which is used by both PowerModels and PowerModelsDistribution).
Many function kwargs were changed to make them more generic to the type of network, and default values were moved in many cases to
src/core/options.jlso it wasn't any longer necessary to monitor many functions across several files to keep them in sync.The load-block variants of the plot and build graph function was removed in favor of using the kwarg
block_graph=true, mainly because the amount of code replication was huge and it was easier to condense down into a single function once the functions were refactored to make them more agnostic to the type of network.An equivalent of plot_load_summary called plot_source_demand_summary specifically for the ENGINEERING model was added. It has some abstractions in it already and may be able to be adapted for other types of Infrastructure networks later, but focuses right now on power.