Various improvements related to the new X-ray transform implemementation. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add 2d projector and code to time it * Clean up * Add back projection * Add test * Add timing results to example * Start to add new example * Update data * Address mypy * Address isort * Try to fix tables in notebook * Update submodule * Rename XRayProject to XRayTransform * Minor edits --------- Co-authored-by: Michael McCann <mccann@.lanl.gov> Co-authored-by: Michael-T-McCann <michael.thompson.mccann@gmail.com> Co-authored-by: Michael McCann <mccann@lanl.gov>
bwohlberg
added
the
improvement
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 94.58% 94.56% -0.02%
==========================================
Files 87 88 +1
Lines 5495 5498 +3
==========================================
+ Hits 5197 5199 +2
- Misses 298 299 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Michael-T-McCann
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements, mostly related to the new X-ray transform implemementation, including renaming of tomographic projector classes for consistency.