Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to scico.flax and related example scripts #498

Merged
merged 42 commits into from
Feb 5, 2024

Conversation

bwohlberg
Copy link
Collaborator

Various improvements to scico.flax and related example scripts, including resolving #493.

@bwohlberg bwohlberg added documentation Improvements or additions to documentation examples Pertaining to SCICO examples improvement Improvement of existing code, including addressing of omissions or inconsistencies labels Feb 1, 2024
@bwohlberg bwohlberg requested a review from crstngc February 1, 2024 01:03
@bwohlberg bwohlberg linked an issue Feb 1, 2024 that may be closed by this pull request
Many of the function and parameter names used in this sub-package are
based on the somewhat non-standard Flax terminology for neural network
components:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please carefully check that the descriptions here are correct.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c483304) 94.78% compared to head (af1d2a7) 94.77%.

❗ Current head af1d2a7 differs from pull request most recent head 28e2f3a. Consider uploading reports for the commit 28e2f3a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   94.78%   94.77%   -0.01%     
==========================================
  Files          91       91              
  Lines        5637     5640       +3     
==========================================
+ Hits         5343     5345       +2     
- Misses        294      295       +1     
Flag Coverage Δ
unittests 94.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bwohlberg bwohlberg merged commit 13ef0a8 into main Feb 5, 2024
18 checks passed
@bwohlberg bwohlberg deleted the brendt/flax branch February 5, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples Pertaining to SCICO examples improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading extension on flax data files
1 participant