PHP 7.4 compatibility #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekatarnls
force-pushed
the
feature/php7.4-compatibility
branch
from
2cce032
to
e39b14b
Compare
kylekatarnls
force-pushed
the
feature/php7.4-compatibility
branch
from
e39b14b
to
a1ff520
Compare
|
Can you update the pr? |
Closed
|
Done. As @szepeviktor noticed here: #303 (comment) There is an other problem to solve in/around ServiceProvider.php. |
|
This incompatibility is not yet fixed by Laravel, it needs: |
|
Meanwhile we may add an empty view config in tests so |
kylekatarnls
force-pushed
the
feature/php7.4-compatibility
branch
from
efcff97
to
b540a1c
Compare
|
Fixed. So no matter Lumen will be compatible to PHP 7.4, we can check than larastan itself is now. |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.