[FEATURE] Doctrine ORM 3.0 & DBAL 4.0 & Doctrine Coding Standard #582
Conversation
TomHAnderson
changed the title
TomHAnderson
changed the title
| "doctrine/dbal": "^4.1", | ||
| "doctrine/orm": "^3.1", |
There was a problem hiding this comment.
Not sure how this is handled on this repository usually, but it might be smart to create releases that support ORM 2 and 3 first, so people can migrate one package at a time. Same for DBAL.
There was a problem hiding this comment.
ORM 3 requires DBAL 4. What my PR proposes is a major version release without a path to migrate "gracefully".
This library is sorely lacking support for the latest Doctrine libraries. If version 2 of this library still works for folks, that's fine. But constant progress on this library is non-existent. It's like the whole team (10 of you?) has dropped their assumed goal of maintaining a world-class library.
It's not uncommon for older packages to lose traction after some time, but this library is the best solution to Doctrine ORM in Laravel and both those projects continue to mature.
There was a problem hiding this comment.
It's like the whole team (10 of you?) has dropped their assumed goal of maintaining a world-class library.
Note that the Doctrine team is not related to this library. I have been the sole "maintainer" of this library for several years. But I almost never contribute myself, it's up to the community to provide pull requests, unless none have provided a pull request before laravel goes out of security updates.
Yes, laravel-doctrine needs a proper maintainer which can lift this package up to latest standard and keep constant progress.
There was a problem hiding this comment.
But this isn't you:
https://github.com/laravel-doctrine/orm/blob/2.0/LICENSE#L3
And this isn't you:
https://github.com/laravel-doctrine/orm/blob/2.0/composer.json#L14-L15
I would like to be that proper maintainer for this organization. I have many Doctrine ORM and Laravel libraries at https://github.com/api-skeletons I am also a member of the Doctrine open source team. My latest project, the LDOG Stack, https://github.com/api-skeletons/ldog, relies on this library as well as my other projects. Reviving this resource is in my best interest.
To see my latest work please review https://github.com/api-skeletons/doctrine-orm-graphql (and be sure to see the documentation).
There was a problem hiding this comment.
I dont feel that I have contributed enough to this repo that I feel I should be on those lists.. :)
I will take a look at your profile. I don't think it will be any problem of giving you access 👌
There was a problem hiding this comment.
As you can see in this composer.json, libraries can be compatible with both ORM 2 and 3 and DBAL 3 and 4.
https://github.com/API-Skeletons/doctrine-orm-graphql/blob/12.2.x/composer.json#L14-L22
I don't foresee version 3 of this library trying to do the same. So I think to catch this library up, ORM 3 should be supported at the highest versions.
|
@eigan Before I do anything within this organization, will you please email me? |
TomHAnderson
force-pushed
the
feature/doctrine-coding-standard
branch
from
e6f1e76 to
50f6bd1
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 3.0.x #582 +/- ##
========================================
Coverage ? 64.04%
Complexity ? 531
========================================
Files ? 76
Lines ? 1677
Branches ? 0
========================================
Hits ? 1074
Misses ? 603
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Merging this without static analysis. Will be addressed in future PR |
Please prefix your pull request with one of the following: [FIX] [FEATURE].
Changes proposed in this pull request:
srcconforms to the Doctrine Coding Standard