Laravel 5.8 support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding support for Laravel 5.8 - Removing support for Laravel 5.3 and 5.4 **(see notes)** - Restricting PHP Version to 7.2 or above as per https://laravel.com/docs/5.8/installation and https://phpunit.de/announcements/phpunit-8.html - Upping PHPUnit requirement to `~8.0`. Laravel 5.8 still technically supports PHPUnit 7 - but Laravel 5.9 very likely won't.
- Removed unsupported PHP Versions and added `PHP 7.2` and `PHP 7.3` to test suite.
Adding `"dms/phpunit-arraysubset-asserts": ">=0.1.0"`
Due to upcoming deprecation.
`setExpectedException` was deprecated. Replaced with `expectException` and `expectExceptionMessage`.
`setExpectedException` is deprecated. Updated to `expectException`.
|
This should be a major release due to breaking backwards compatibility. |
|
Please merge this :-) |
|
Sorry for the delay, nice work @CmdrSharp! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
~8.0. Laravel 5.8 still technically supports PHPUnit 7 - but Laravel 5.9 very likely won't due to PHP Version requirement changes.mockeryrequirement to^1.0require-devdue toassertArraySubsetbeing deprecated in PHPUnit 9.Notes:
Compatibility with older orchestra/testbench releases has to go if we want to use newer PHPUnit versions.
Furthermore, this release should (in my opinion) stop supporting PHP 5.6, 7.0 and 7.1 - all of which are EOL.
Fixes:
This fixes #29.