Add support for image attachment #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
boryn
commented
Aug 8, 2021
•
boryn
commented
- Message accepts now image() method.
- The message is sent using the multipart/form-data form (with or without the image).
- If there is any error with the image, it is silently omitted and the message is sent without the attachment.
Closed
boryn
force-pushed
the
image-support
branch
2 times, most recently
from
39fc5d3 to
871676c
Compare
Kovah
requested changes
Apr 1, 2023
There was a problem hiding this comment.
I have tested this locally and it work's without issues. Maybe after merging the error handling could be improved by logging issues instead of silently discarding them.
One thing missing would be tests. At least the basic ones like in PushoverMessageTest for setting and retrieving the image path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.