Add PaymentMethod type parameter to ManagesPaymentMethods #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @simonhir. This indeed needs to go to master because other than the change in behavior this also breaks the method signatures. Feel free to send this to master and I'll try to take a look soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
$typeparameter to have the possibility to retrieve other payment methods from Stripe thancard.Should fix #507
This probably should go on
masteras thecard_brand-field now containscardinstead ofvisaormastercard.Would be nice if somebody could say if this is more a Minor or a Major version feature and so on if I should provide the backwards compatibility.