New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rawDiscountFor returns first() StripeObject from collection #1324

Closed

markkimsal wants to merge 1 commit into laravel:13.x from markkimsal:fixes/dockblock-rawDiscountFor

markkimsal commented Feb 20, 2022

rawDiscountFor returns a StripeObject or null, not an int. The usage of the return value as an object is displayed in discountFor

        if (! is_null($discountAmount = $this->rawDiscountFor($discount))) {
            return $this->formatAmount($discountAmount->amount);
        }


          docs: rawDiscountFor returns first() StripeObject from collection

2ea7bd0

driesvints marked this pull request as draft

February 20, 2022 17:23

Member

driesvints commented Feb 21, 2022

Heya, I sent in an alternative PR that'll fix the method's return value instead. Thanks!

driesvints closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet