[14.x] Fix wrong foreignKey on SubscriptionItem #1494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an error in the relationship between items and subscription when using custom models
i.e. using
With these I think "licit" migrations
current codebase works in finding the items from the subscription, but not in finding the subscription from the items.
so $item->subscription will never works without this fix.
Of course, it can be solved by overriding the relation in our custom SubscriptionItemModel..
but I think that is a correct pr.