Update PaymentMethod.php #1601
Merged
Update PaymentMethod.php #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the docstring to return `void`, since that is what the `deletePaymentMethod` function actually returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docstring to return
void, since that is what thedeletePaymentMethodfunction actually returnsReason for change: We had assumed from VSCode's reference to the
deletemethod that something was returned. As such, we checked the truthy-ness of that return to flag if there were any issues.The issue is that the true return was
void. A better solution would be to actually add the return hint as part of the function itself, but this is the lightest lift with no code changes I could think of. And it fixes any future confusion for this function.See #1568 for documentation of the issue