[15.x] Stripe API and SDK update #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
commented
Dec 13, 2023
| $parameters = array_merge([ | ||
| 'automatic_tax' => $this->automaticTaxPayload(), | ||
| 'customer' => $this->stripe_id, | ||
| 'currency' => $stripeCustomer->currency ?? config('cashier.currency'), |
There was a problem hiding this comment.
There cannot be multiple currencies anymore on invoices so we'll use the one from the customer or fallback to the Cashier default.
driesvints
commented
Dec 13, 2023
| if (isset($parameters['subscription'])) { | ||
| unset($parameters['currency']); | ||
| } | ||
|
|
There was a problem hiding this comment.
currency cannot be combined with subscription so we allow subscription to take precedence.
driesvints
commented
Dec 13, 2023
| if ($options['confirm'] ?? false) { | ||
| $options['return_url'] ??= route('home'); | ||
| } | ||
|
|
There was a problem hiding this comment.
When a payment intent is being confirmed, we'll always need to supply a return url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Stripe API to the most recent one
2023-10-16as well as update the SDK version to v13 which is compatible with it.I also decided to drop support for older SDK versions because v13 is the one that's compatible with this API version.
Closes #1556