New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Add Missing @throws tags #813

Merged

taylorotwell merged 1 commit into laravel:10.0 from ericdowell:missing-phpdoc-throws

Nov 4, 2019

Contributor

ericdowell commented Nov 3, 2019

Adds missing PHPDocs @throws for create/add methods on Laravel\Cashier\SubscriptionBuilder class.

This aligns with what is described in Upgrading To 10.0 From 9.0: https://github.com/laravel/cashier/blob/master/UPGRADE.md#new-exceptions


          Adding missing phpdocs for throws on create/add methods.

4acba74

driesvints approved these changes

View reviewed changes

Member

driesvints left a comment

These methods don't throw these exceptions but given the nature of the meaning of these exception I can understand adding them here. So ok for me.

taylorotwell merged commit 7ab823d into laravel:10.0

ericdowell deleted the missing-phpdoc-throws branch

November 13, 2019 03:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet