[11.x] Add subscription options + test #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Feb 17, 2020
driesvints
changed the title
driesvints
requested changes
Feb 17, 2020
…ier into add_subscription_options
driesvints
approved these changes
Feb 17, 2020
|
@keithbrink thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to support additional subscriptions options, and resolves #787
I was thinking about passing $subscriptionOptions and $customer into the buildPayload function, but ultimately decided to keep the PR simple. Let me know if you'd prefer the array merge to happen in the buildPayload function.