Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe configuration merging in the upgrade guide #10013

Closed
wants to merge 1 commit into from

Conversation

tontonsb
Copy link
Contributor

@tontonsb tontonsb commented Nov 4, 2024

The issues that arise because of the automatic configuration merging are very rare, but easy to miss if you run into them. And the fix is hard to discover. Therefore it feels appropriate to add some documentation on that.

I tried to document the disabling option without encouraging it's use.

It appears to mostly affect people doing foreach (config('database.connections') as $connection) or foreach (config('queue.connections') as $connection) which should probably be rewritten to something like

foreach (['core', 'mail'] as $conn) {  // or foreach (config('queue.enabled_connections') as $conn)
    $connection = config('queue.connections')[$conn];
}

but I doubt the issue is common enough to add solution suggestions.

Prev discussions and issues with the change:

@taylorotwell
Copy link
Member

I think I'll let it ride without this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants