added whereBelongsTo methods in where section of query builder docs introduced in Laravel 8.63.0. #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it belongs there. I already documented it in Eloquent relationship docs. |
|
Glad to know that that's already there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the new method
whereBelongsTowith a description in the Additional Where Clauses section of the query builder documentation page. New feature PR is here laravel/framework#38927Most of the description is taken from the PR and it feels suitable to me. I'm open to any change for choosing words or the best place for this method.
Attached is the SS of rendered markdown my PHPStorm.