Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Document Script & Style Attributes with Vite #8086

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Conversation

jessarcher
Copy link
Member

This PR adds documentation for laravel/framework#43442 which allows developers to configure CSP, SRI, and other arbitrary attributes on the script and style tags generated by Laravel when using Vite.

@jessarcher jessarcher force-pushed the vite-attributes branch 3 times, most recently from 841e8fd to 458d325 Compare August 1, 2022 01:28
@jessarcher jessarcher marked this pull request as ready for review August 1, 2022 01:30
@taylorotwell taylorotwell merged commit 2639875 into 9.x Aug 1, 2022
@taylorotwell taylorotwell deleted the vite-attributes branch August 1, 2022 16:13
{
Vite::useCspNonce();

return $next($response)->withHeaders([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessarcher Shouldn't this be return $next($request)->withHeaders([ ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

PR to fix it: #8097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants