Support Dusk Selectors in screenshotElement (#1094)

* Add Helper: `elementScreenshot` * Tests added for new helper `elementScreenshot` * rename method * Support Dusk Selectors in `screenshotElement` * Fix test for `screenshotElement` --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
laravel · Mar 24, 2024 · 1bdefcf · 1bdefcf
1 parent 783382b
commit 1bdefcf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Browser.php b/src/Browser.php
@@ -466,7 +466,7 @@ public function screenshotElement($selector, $name)
         }
 
         $this->scrollIntoView($selector)
-            ->driver->findElement(WebDriverBy::cssSelector($selector))
+            ->driver->findElement(WebDriverBy::cssSelector($this->resolver->format($selector)))
             ->takeElementScreenshot($filePath);
 
         return $this;

diff --git a/tests/Unit/BrowserTest.php b/tests/Unit/BrowserTest.php
@@ -244,7 +244,7 @@ public function test_screenshot_in_subdirectory()
         $this->assertFileExists(Browser::$storeScreenshotsAt.'/'.$name.'.png');
     }
 
-    public function test_element_screenshot()
+    public function test_screenshot_element()
     {
         $elementMock = $this->createMock(RemoteWebElement::class);
         $elementMock->expects($this->once())
@@ -256,7 +256,7 @@ public function test_element_screenshot()
         $driverMock = $this->createMock(RemoteWebDriver::class);
         $driverMock->expects($this->once())
             ->method('findElement')
-            ->with(WebDriverBy::cssSelector('#selector'))
+            ->with(WebDriverBy::cssSelector('body #selector'))
             ->willReturn($elementMock);
 
         $browser = new Browser($driverMock);
@@ -271,7 +271,7 @@ public function test_element_screenshot()
         $this->assertFileExists(Browser::$storeScreenshotsAt.'/'.$name.'.png');
     }
 
-    public function test_element_screenshot_in_subdirectory()
+    public function test_screenshot_element_in_subdirectory()
     {
         $elementMock = $this->createMock(RemoteWebElement::class);
         $elementMock->expects($this->once())
@@ -283,7 +283,7 @@ public function test_element_screenshot_in_subdirectory()
         $driverMock = $this->createMock(RemoteWebDriver::class);
         $driverMock->expects($this->once())
             ->method('findElement')
-            ->with(WebDriverBy::cssSelector('#selector'))
+            ->with(WebDriverBy::cssSelector('body #selector'))
             ->willReturn($elementMock);
 
         $browser = new Browser($driverMock);