[8.x] Extract chromedriver regardless of position in archive #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
approved these changes
Aug 13, 2024
u01jmg3
reviewed
Aug 13, 2024
| @@ -217,26 +216,34 @@ protected function download($version, $os) | |||
| * @param string $archive | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks! Updated the extract docblock.
There was a problem hiding this comment.
The other thing I noticed is elsewhere in Dusk they state @throws \Exception.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to do a small refactor to prevent dusk breaking if Chrome annoyingly change the order of, or add files in their driver zip archive.
It looks through the archive and only extracts files beginning with
chromedriver. This should handle all windows, linux and mac chromedriver files.