Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Firefox users disable console #355

Merged
merged 4 commits into from
Sep 6, 2017
Merged

Let Firefox users disable console #355

merged 4 commits into from
Sep 6, 2017

Conversation

deleugpn
Copy link
Contributor

@deleugpn deleugpn commented Sep 6, 2017

An alternative to #354.

When using Firefox, simply override the setUp method.

    protected function setUp()
    {
        parent::setUp();

        // Any of the following will be a valid option. The user can choose one
        Browser::$storeConsoleLogAt = null;
        Browser::$storeConsoleLogAt = false;
        Browser::$storeConsoleLogAt = '';
        unset(Browser::$storeConsoleLogAt);
    }
  • Why Firefox users should disable this themselves?

Dusk relies on Selenium to communicate with the browser and Selenium does offer getLog API (https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#log-type). Firefox hasn't caught up with that yet so if you do use Selenium with Firefox and make this API call, Firefox driver will fail and bubble up to Selenium. It doesn't necessarily mean that only Chrome offers this. PhantomJS is an example of that.

@taylorotwell taylorotwell merged commit 345d5a6 into laravel:2.0 Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants