Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Namespace make command #134

Merged
merged 3 commits into from
May 7, 2024
Merged

[1.x] Namespace make command #134

merged 3 commits into from
May 7, 2024

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Mar 16, 2024

Docs: laravel/docs#9510

Namespaces folio's make command.

It is currently inconsistent with the rest of the ecosystem.

make:folio
pennant:feature
dusk:make
dusk:page
dusk:component

make:folio => folio:page

folio:page
pennant:feature
dusk:make
dusk:page
dusk:component

folio:make is also an option, but I liked that the command still expresses what it makes, i.e., a page.

@timacdonald timacdonald changed the title Namespace make command [1.x] Namespace make command Mar 16, 2024
@timacdonald timacdonald marked this pull request as draft March 16, 2024 23:51
@inmanturbo
Copy link
Contributor

@timacdonald for some reason every time I go to creat a folio "page" I type

php artisan folio:route "path/to/file"

😅

Idk why. In a way I guess it's like adding a route. Incidentally livewire/volt is very similar to the current signature make:volt.

Anyway it breaks the signature but it won't break applications. Namespacing is a good idea and an improvement, I think.

@inmanturbo
Copy link
Contributor

Honestly I just wish you could pass a stub to the underlying make command as an option. I might work on that if I get a chance. Always want different stubs for different types of pages (or components)

@timacdonald timacdonald marked this pull request as ready for review May 6, 2024 03:45
@timacdonald timacdonald marked this pull request as draft May 6, 2024 03:46
@timacdonald timacdonald marked this pull request as ready for review May 7, 2024 07:04
@taylorotwell taylorotwell merged commit 3b6e8de into master May 7, 2024
11 checks passed
@taylorotwell taylorotwell deleted the namespace-command branch May 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants