Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deployment command showing wrong output #88

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

olivernybroe
Copy link
Contributor

Deployment command was looking for an event id by the description, however deployment commands always have the same description. This resulted in it getting the previous deployment output.

Changed to use deployment id for finding deployment output instead of event id.

@olivernybroe olivernybroe requested review from a team, jbrooksuk and claudiodekker and removed request for a team June 24, 2024 09:28
Deployment command was looking for an event id by the description, however deployment commands always have the same description. This resulted in it getting the previous deployment output. Changed to use deployment id for finding deployment output instead of event id.
@olivernybroe olivernybroe force-pushed the fix_deployment_output branch from de47a97 to bc6ac89 Compare June 24, 2024 09:29
app/Commands/DeployCommand.php Outdated Show resolved Hide resolved
app/Commands/DeployCommand.php Outdated Show resolved Hide resolved
app/Commands/DeployCommand.php Outdated Show resolved Hide resolved
@olivernybroe olivernybroe requested a review from jbrooksuk June 24, 2024 10:16
@olivernybroe olivernybroe merged commit 237a34a into master Jun 24, 2024
2 checks passed
@olivernybroe olivernybroe deleted the fix_deployment_output branch June 24, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants