Helpers classes for known values #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooksuk
approved these changes
Sep 11, 2020
jbrooksuk
requested changes
Sep 11, 2020
| const CUSTOM = 'custom'; | ||
| const DIGITAL_OCEAN = 'ocean2'; | ||
| const HETZNER = 'hetzner'; | ||
| const LINODE = 'linode'; |
There was a problem hiding this comment.
I believe this should be linode4.
Ping @themsaid
driesvints
approved these changes
Sep 11, 2020
|
Can you submit this to the 3.x branch please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (based on #46) adds helper classes for known values when performing operations with Server in Laravel Forge, the main purpose of these classes is to provide a better and more user-friendly way of specifying server requirements.
There is no contributing file so please guide me through the required changes if needed, I will be more than happy to adjust the code to fit your specifications.
The additions are:
Previous discusion on #81