Update Command::fail() dockblock and tests (#51914)

laravel · Jun 26, 2024 · 1076c91 · 1076c91
1 parent fe4f3dc
commit 1076c91
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/Illuminate/Console/Command.php b/src/Illuminate/Console/Command.php
@@ -266,6 +266,8 @@ protected function resolveCommand($command)
      *
      * @param  \Throwable|string|null  $exception
      * @return void
+     *
+     * @throws \Illuminate\Console\ManuallyFailedException|\Throwable
      */
     public function fail(Throwable|string|null $exception = null)
     {

diff --git a/tests/Integration/Console/CommandManualFailTest.php b/tests/Integration/Console/CommandManualFailTest.php
@@ -28,16 +28,30 @@ public function testFailArtisanCommandManually()
     public function testCreatesAnExceptionFromString()
     {
         $this->expectException(ManuallyFailedException::class);
+        $this->expectExceptionMessage('Whoops!');
         $command = new Command;
         $command->fail('Whoops!');
     }
 
     public function testCreatesAnExceptionFromNull()
     {
         $this->expectException(ManuallyFailedException::class);
+        $this->expectExceptionMessage('Command failed manually.');
         $command = new Command;
         $command->fail();
     }
+
+    public function testThrowsTheOriginalThrowableInstance()
+    {
+        try {
+            $command = new Command;
+            $command->fail($original = new \RuntimeException('Something went wrong.'));
+
+            $this->fail('Command::fail() method must throw the original throwable instance.');
+        } catch (\Throwable $e) {
+            $this->assertSame($original, $e);
+        }
+    }
 }
 
 class FailingCommandStub extends Command