formatting

laravel · Nov 8, 2018 · 3992140 · vlakoff · Nov 11, 2018 · vlakoff
1 parent df2cf1f
commit 3992140
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php b/src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php
@@ -83,7 +83,7 @@ public function addEagerConstraints(array $models)
     {
         $whereIn = in_array($this->parent->getKeyType(), ['int', 'integer']) ? 'whereInRaw' : 'whereIn';
 
-        $this->query->$whereIn(
+        $this->query->{$whereIn}(
             $this->foreignKey, $this->getKeys($models, $this->localKey)
         );
     }

diff --git a/src/Illuminate/Database/Query/Grammars/Grammar.php b/src/Illuminate/Database/Query/Grammars/Grammar.php
@@ -304,6 +304,8 @@ protected function whereNotInSub(Builder $query, $where)
     /**
      * Compile a "where in raw" clause.
      *
+     * For safety, this method is only used with integer values as whereInRaw utilizes "intval".
+     *
      * @param  \Illuminate\Database\Query\Builder  $query
      * @param  array  $where
      * @return string