Fix the dump method for LazyCollection (#33944)

laravel · Aug 20, 2020 · 455b343 · 455b343
1 parent 28f847f
commit 455b343
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/Illuminate/Support/Traits/EnumeratesValues.php b/src/Illuminate/Support/Traits/EnumeratesValues.php
@@ -181,8 +181,8 @@ public function dd(...$args)
      */
     public function dump()
     {
-        (new static(func_get_args()))
-            ->push($this)
+        (new Collection(func_get_args()))
+            ->push($this->all())
             ->each(function ($item) {
                 VarDumper::dump($item);
             });

diff --git a/tests/Support/SupportCollectionTest.php b/tests/Support/SupportCollectionTest.php
@@ -18,6 +18,7 @@
 use PHPUnit\Framework\TestCase;
 use ReflectionClass;
 use stdClass;
+use Symfony\Component\VarDumper\VarDumper;
 
 class SupportCollectionTest extends TestCase
 {
@@ -3419,6 +3420,24 @@ public function testConcatWithCollection($collection)
         $this->assertSame($expected, $actual);
     }
 
+    /**
+     * @dataProvider collectionClassProvider
+     */
+    public function testDump($collection)
+    {
+        $log = new Collection();
+
+        VarDumper::setHandler(function ($value) use ($log) {
+            $log->add($value);
+        });
+
+        (new $collection([1, 2, 3]))->dump('one', 'two');
+
+        $this->assertSame(['one', 'two', [1, 2, 3]], $log->all());
+
+        VarDumper::setHandler(null);
+    }
+
     /**
      * @dataProvider collectionClassProvider
      */