[11.x] Add HasFactory trait to make:model generation command usin…

…g `--all` options (#53391) * Add HasFactory support to model generation * Add test for model generation with HasFactory trait * wip * Delete tests/Feature/ModelMakeCommandTest.php * Update ModelMakeCommandTest.php * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> --------- Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
laravel · Nov 5, 2024 · 488b367 · 488b367
1 parent eb4d629
commit 488b367
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/src/Illuminate/Foundation/Console/ModelMakeCommand.php b/src/Illuminate/Foundation/Console/ModelMakeCommand.php
@@ -251,7 +251,7 @@ protected function buildFactoryReplacements()
     {
         $replacements = [];
 
-        if ($this->option('factory')) {
+        if ($this->option('factory') || $this->option('all')) {
             $modelPath = str($this->argument('name'))->studly()->replace('/', '\\')->toString();
 
             $factoryNamespace = '\\Database\\Factories\\'.$modelPath.'Factory';

diff --git a/tests/Integration/Generators/ModelMakeCommandTest.php b/tests/Integration/Generators/ModelMakeCommandTest.php
@@ -11,6 +11,7 @@ class ModelMakeCommandTest extends TestCase
         'app/Http/Controllers/BarController.php',
         'database/factories/FooFactory.php',
         'database/factories/Foo/BarFactory.php',
+        'database/migrations/*_create_foos_table.php',
         'database/seeders/FooSeeder.php',
         'tests/Feature/Models/FooTest.php',
     ];
@@ -144,6 +145,32 @@ public function testItCanGenerateModelFileWithFactoryOptionForDeepFolder()
         $this->assertFilenameNotExists('database/seeders/Foo/BarSeeder.php');
     }
 
+    public function testItGeneratesModelWithHasFactoryTraitWhenUsingAllOption()
+    {
+        $this->artisan('make:model', ['name' => 'Foo', '--all' => true])
+            ->expectsQuestion('A App\Models\Foo model does not exist. Do you want to generate it?', false)
+            ->assertExitCode(0);
+
+        $this->assertFileContains([
+            'namespace App\Models;',
+            'use Illuminate\Database\Eloquent\Factories\HasFactory;',
+            'use Illuminate\Database\Eloquent\Model;',
+            'class Foo extends Model',
+            '/** @use HasFactory<\Database\Factories\FooFactory> */',
+            'use HasFactory;',
+        ], 'app/Models/Foo.php');
+
+        $this->assertFileNotContains([
+            '{{ factoryImport }}',
+            '{{ factory }}',
+        ], 'app/Models/Foo.php');
+
+        $this->assertFilenameExists('app/Http/Controllers/FooController.php');
+        $this->assertFilenameExists('database/factories/FooFactory.php');
+        $this->assertFilenameExists('database/seeders/FooSeeder.php');
+        $this->assertMigrationFileExists('create_foos_table.php');
+    }
+
     public function testItCanGenerateModelFileWithMigrationOption()
     {
         $this->artisan('make:model', ['name' => 'Foo', '--migration' => true])