Remove serializer option for now

laravel · Feb 10, 2020 · 9e20ec6 · 9e20ec6
1 parent 6088728
commit 9e20ec6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/src/Illuminate/Redis/Connectors/PhpRedisConnector.php b/src/Illuminate/Redis/Connectors/PhpRedisConnector.php
@@ -98,10 +98,6 @@ protected function createClient(array $config)
                 $client->setOption(Redis::OPT_READ_TIMEOUT, $config['read_timeout']);
             }
 
-            if (! empty($config['serializer'])) {
-                $client->setOption(Redis::OPT_SERIALIZER, $config['serializer']);
-            }
-
             if (! empty($config['scan'])) {
                 $client->setOption(Redis::OPT_SCAN, $config['scan']);
             }
@@ -160,16 +156,12 @@ protected function createRedisClusterInstance(array $servers, array $options)
                 $client->setOption(RedisCluster::OPT_PREFIX, $options['prefix']);
             }
 
-            if (! empty($options['serializer'])) {
-                $client->setOption(RedisCluster::OPT_SERIALIZER, $options['serializer']);
-            }
-
-            if (! empty($config['scan'])) {
-                $client->setOption(RedisCluster::OPT_SCAN, $config['scan']);
+            if (! empty($options['scan'])) {
+                $client->setOption(RedisCluster::OPT_SCAN, $options['scan']);
             }
 
-            if (! empty($config['failover'])) {
-                $client->setOption(RedisCluster::OPT_SLAVE_FAILOVER, $config['failover']);
+            if (! empty($options['failover'])) {
+                $client->setOption(RedisCluster::OPT_SLAVE_FAILOVER, $options['failover']);
             }
         });
     }

diff --git a/tests/Redis/RedisConnectionTest.php b/tests/Redis/RedisConnectionTest.php
@@ -162,6 +162,7 @@ public function testItAddsMembersToSortedSet()
             $this->assertEquals(0, $redis->zadd('set', 'XX', 'CH', ['arya' => 11]));
 
             $redis->zadd('set', ['mohamed' => 100]);
+            dump($redis->zscore('set', 'mohamed'));
             $this->assertEquals(100, $redis->zscore('set', 'mohamed'));
 
             $redis->flushall();