Skip to content

Commit

Permalink
[8.x] Change to X-Message-ID in Mailgun and Ses Transport (#34567)
Browse files Browse the repository at this point in the history
* Change to X-Message-ID in mail transport

* Fixed incorrect usage of addTextHeader

* Updated test for 'X-Message-ID'

* Updated test for X-Message-ID in SesTransport

* Fixed code syntax

* Update MailgunTransport.php

* Update SesTransport.php

* Update MailSesTransportTest.php

Co-authored-by: Taylor Otwell <taylor@laravel.com>
  • Loading branch information
u12206050 and taylorotwell authored Sep 28, 2020
1 parent 2ec7738 commit f4867e6
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
7 changes: 4 additions & 3 deletions src/Illuminate/Mail/Transport/MailgunTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,10 @@ public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = nul
$this->payload($message, $to)
);

$message->getHeaders()->addTextHeader(
'X-Mailgun-Message-ID', $this->getMessageId($response)
);
$messageId = $this->getMessageId($response);

$message->getHeaders()->addTextHeader('X-Message-ID', $messageId);
$message->getHeaders()->addTextHeader('X-Mailgun-Message-ID', $messageId);

$message->setBcc($bcc);

Expand Down
5 changes: 4 additions & 1 deletion src/Illuminate/Mail/Transport/SesTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = nul
)
);

$message->getHeaders()->addTextHeader('X-SES-Message-ID', $result->get('MessageId'));
$messageId = $result->get('MessageId');

$message->getHeaders()->addTextHeader('X-Message-ID', $messageId);
$message->getHeaders()->addTextHeader('X-SES-Message-ID', $messageId);

$this->sendPerformed($message);

Expand Down
4 changes: 3 additions & 1 deletion tests/Mail/MailSesTransportTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function testSend()
$transport = new SesTransport($client);

// Generate a messageId for our mock to return to ensure that the post-sent message
// has X-SES-Message-ID in its headers
// has X-Message-ID in its headers
$messageId = Str::random(32);
$sendRawEmailMock = new sendRawEmailMock($messageId);
$client->expects($this->once())
Expand All @@ -64,6 +64,8 @@ public function testSend()
->willReturn($sendRawEmailMock);

$transport->send($message);

$this->assertEquals($messageId, $message->getHeaders()->get('X-Message-ID')->getFieldBody());
$this->assertEquals($messageId, $message->getHeaders()->get('X-SES-Message-ID')->getFieldBody());
}
}
Expand Down

0 comments on commit f4867e6

Please sign in to comment.