Do not trigger missing translation key handling when checking existen…

…ce of that key (#52895)
laravel · Sep 24, 2024 · f8f0668 · f8f0668
1 parent a84070d
commit f8f0668
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Illuminate/Translation/Translator.php b/src/Illuminate/Translation/Translator.php
@@ -117,8 +117,14 @@ public function has($key, $locale = null, $fallback = true)
     {
         $locale = $locale ?: $this->locale;
 
+        $handleMissingTranslationKeys = $this->handleMissingTranslationKeys;
+
+        $this->handleMissingTranslationKeys = false;
+
         $line = $this->get($key, [], $locale, $fallback);
 
+        $this->handleMissingTranslationKeys = $handleMissingTranslationKeys;
+
         // For JSON translations, the loaded files will contain the correct line.
         // Otherwise, we must assume we are handling typical translation file
         // and check if the returned line is not the same as the given key.

diff --git a/tests/Integration/Translation/TranslatorTest.php b/tests/Integration/Translation/TranslatorTest.php
@@ -41,6 +41,19 @@ public function testItCanCheckLanguageExistsHasFromLocaleForJson()
         $this->assertTrue($this->app['translator']->hasForLocale('30 Days'));
     }
 
+    public function testItCanCheckKeyExistsWithoutTriggeringHandleMissingKeys()
+    {
+        $this->app['translator']->handleMissingKeysUsing(function ($key) {
+            $_SERVER['__missing_translation_key'] = $key;
+        });
+
+        $this->assertFalse($this->app['translator']->has('Foo Bar'));
+        $this->assertFalse(isset($_SERVER['__missing_translation_key']));
+
+        $this->assertFalse($this->app['translator']->hasForLocale('Foo Bar', 'nl'));
+        $this->assertFalse(isset($_SERVER['__missing_translation_key']));
+    }
+
     public function testItCanHandleMissingKeysUsingCallback()
     {
         $this->app['translator']->handleMissingKeysUsing(function ($key) {